From flirtations with skirting term limits, to suffocating agreements with major law firms, President Trump is once again re-asserting his status as a perpetual controversy magnet.